Loading Profile...
Are review links broken?
I enabled Campfire integration, and the review link that it dumps into the chat is formatted as so (my personal URL/repo bits removed): http://[myapp].beanstalkapp.com/u/e45b07b6
Which generates this URL: http://[myapp].beanstalkapp.com/[myrepo]/changesets/preview/17/index.php
Which nets me a 404 page. From within Beanstalk, however, the review link works fine, but is a bit different: http://[myapp].beanstalkapp.com/[myrepo]/browse/trunk/index.php?rev=17
This is the "preview" link available from that browse page: http://[myapp].beanstalkapp.com/[myrepo]/live/trunk/index.php
You can contact me for specific details, but I'm guessing it's not unique to me, and I'm guessing it's something along the lines of routes changing but nobody telling the review link generator.
Which generates this URL: http://[myapp].beanstalkapp.com/[myrepo]/changesets/preview/17/index.php
Which nets me a 404 page. From within Beanstalk, however, the review link works fine, but is a bit different: http://[myapp].beanstalkapp.com/[myrepo]/browse/trunk/index.php?rev=17
This is the "preview" link available from that browse page: http://[myapp].beanstalkapp.com/[myrepo]/live/trunk/index.php
You can contact me for specific details, but I'm guessing it's not unique to me, and I'm guessing it's something along the lines of routes changing but nobody telling the review link generator.
I’m meh
1 person has this problem
I have this problem, too!
Tell me when someone solves it.
The more people who report this problem, the more it gets noticed.
The more people who report this problem, the more it gets noticed.
The best solution from the company
-
Thanks for posting this. We will check the redirect.
Chris
The company says
this solves the problem
-
Inappropriate?As a quick followup, I should note: the changeset link that is inserted into Campfire works fine and points to the appropriate page (http://[myapp].beanstalkapp.com/u/99ca3e79 pointing to http://[myapp].beanstalkapp.com/[myrepo]/changesets/17), it's just the review link (triggered by the [review:index.php] tag) that was broken. Sorry for the miscommunication. -
Inappropriate?Thanks for posting this. We will check the redirect.
Chris
The company says
this solves the problem
-
Inappropriate?Please give it a try now. We have to update the copy on the explanation pages.
When specifying the file, you should use the path to the file. This will avoid problems if there are files in other directories with the same name.
[review:/trunk/filename.html]
Let me know if you still have problems with it and we will deploy another fix.
Thanks,
Chris
EMPLOYEE