appAPI.ready() does not fire on tabs on Safari opened by clicking on links with target="_blank".

Edit Subject

app.API.ready(..) in Safari does not fire reliably. I have come up with the following minimal repro:

I have two simple web pages test.html and test2.html with the following HTML:

test.html:
<html><body><a href="test2.html" target="_blank">Click to go to 2</a></body></html>

test2.html:
<html><body><a href="test.html" target="_blank">Click to go back to 1</a></body></html>

I am using a pared down extension 47884. I installed this extension on Safari by downloading, xar -xf and then using Safari Extension Builder to install and inspect the background page.

Observation

When I load test.html by typing in the URL in the address bar, app.API.ready(..) is fired in extension.js and appropriate console messages are printed both in developer tools as well as the inspection page.

When I click on the "Click to go to 2" link, a new tab opens with test2.html. However in this tab app.API.ready(..) is NOT fired in extension.js. If I type in the URL manually or refresh the page, it gets fired.

What is problematic is that this is not 100% reproducible. If I click on the link 10 times, occasionally it will start firing at the 5th or the 6th attempt and all attempts thereafter. If I kill Safari and restart, problem reappears.

Safari Version: 6.0.5 (8536.30.1)
Mac OS X Mountain Lion (10.8.5)

3 people have
this problem +1

EMPLOYEE

0

Edit

Delete

Remove

Official

Fork

Shlomo (Official Rep) December 12, 2013 10:49

Hello Sujoy,

Thank you for the report. We will investigate this matter as part of our Safari overhaul project early next year. For the latest information about API changes, I recommend that you monitor our changelog and/or changelog RSS feed

In the meantime, you can try working around the issue by introducing additional checks to the extension, a delay in running your extension, or running your code outside of appAPI.ready and use $(document).ready instead.

Comment

good solution! good solution! (undo)
- Cancel
Edit Your Reply (some HTML allowed)
What's the status of this problem?

Hello Sujoy, Thank you for the report. We will investigate this matter as part of our Safari overhaul project early next year. For the latest information about API changes, I recommend that you monitor our <a href="http://docs.crossrider.com/#!/guide/changelog" target="_blank">changelog</a> and/or <a href="http://docs.crossrider.com/guides/changelog/rss.php" target="_blank">changelog RSS feed</a> In the meantime, you can try working around the issue by introducing additional checks to the extension, a delay in running your extension, or running your code outside of <a href='http://docs.crossrider.com/#!/api/appAPI-method-ready' target='_blank'>appAPI.ready</a> and use $(document).ready instead.

How does this make you feel? Add Image

I'm
e.g. sad, anxious, confused, frustrated happy, confident, thankful, excited kidding, amused, unsure, silly indifferent, undecided, unconcerned
Cancel
0

Edit

Delete

Remove

Official

Fork

Sujoy Gupta December 12, 2013 22:25

@Shlomo,

Thanks for the reply. I can wait for a few weeks for this to come in since I have a workaround (opening the tab from the extension rather than by clicking on a link).

However, it will be great if you could confirm that it indeed is a problem, so I can take it off my checklist at my end for now.

Comment

good solution! good solution! (undo)
- Cancel
Edit Your Reply (some HTML allowed)
What's the status of this problem?

@Shlomo, Thanks for the reply. I can wait for a few weeks for this to come in since I have a workaround (opening the tab from the extension rather than by clicking on a link). However, it will be great if you could confirm that it indeed is a problem, so I can take it off my checklist at my end for now.

How does this make you feel? Add Image

I'm
e.g. sad, anxious, confused, frustrated happy, confident, thankful, excited kidding, amused, unsure, silly indifferent, undecided, unconcerned
Cancel
EMPLOYEE

0

Edit

Delete

Remove

Official

Fork

Shlomo (Official Rep) December 15, 2013 18:59

Hello Sujoy,

At this time I can't confirm it is a problem, but I suspect it may be ;-)

Comment

good solution! good solution! (undo)
- Cancel
Edit Your Reply (some HTML allowed)
What's the status of this problem?

Hello Sujoy, At this time I can't confirm it is a problem, but I suspect it may be ;-)

How does this make you feel? Add Image

I'm
e.g. sad, anxious, confused, frustrated happy, confident, thankful, excited kidding, amused, unsure, silly indifferent, undecided, unconcerned
Cancel
I’m frustrated

0

Edit

Delete

Remove

Official

Fork

Sujoy Gupta March 26, 2014 07:46

@Shlomo, this problem still exists. Has anyone looked at it?

I can no longer use my workaround due to another issue and this has become a blocker.

Comment

good solution! good solution! (undo)
- Cancel
Edit Your Reply (some HTML allowed)
What's the status of this problem?

@Shlomo, this problem still exists. Has anyone looked at it? I can no longer use my workaround due to another issue and this has become a blocker.

How does this make you feel? Add Image

I'm
e.g. sad, anxious, confused, frustrated happy, confident, thankful, excited kidding, amused, unsure, silly indifferent, undecided, unconcerned
Cancel
EMPLOYEE
I’m sad

0

Edit

Delete

Remove

Official

Fork

Shlomo (Official Rep) March 26, 2014 09:01

Hello Sujoy,

The dev team looked into this and it's not a simple fix. They have added it to their Safari dev queue but it will probably be quite some time before it's resolved.

Comment

good solution! good solution! (undo)
- Cancel
Edit Your Reply (some HTML allowed)
What's the status of this problem?

Hello Sujoy, The dev team looked into this and it's not a simple fix. They have added it to their Safari dev queue but it will probably be quite some time before it's resolved.

How does this make you feel? Add Image

I'm
e.g. sad, anxious, confused, frustrated happy, confident, thankful, excited kidding, amused, unsure, silly indifferent, undecided, unconcerned
Cancel
0

Edit

Delete

Remove

Official

Fork

Sujoy Gupta March 26, 2014 09:06

@Shlomo, could you pass along some information on what the problem is? I may be able to figure out a workaround which may turn out to be helpful to your dev team. I am good at this sort of thing.

Comment

good solution! good solution! (undo)
- Cancel
Edit Your Reply (some HTML allowed)
What's the status of this problem?

@Shlomo, could you pass along some information on what the problem is? I may be able to figure out a workaround which may turn out to be helpful to your dev team. I am good at this sort of thing.

How does this make you feel? Add Image

I'm
e.g. sad, anxious, confused, frustrated happy, confident, thankful, excited kidding, amused, unsure, silly indifferent, undecided, unconcerned
Cancel
0

Edit

Delete

Remove

Official

Fork

Sujoy Gupta March 27, 2014 20:06

@Shlomo, I will appreciate some info on what the problem is so that I can find a workaround on my end. This is a blocker.

Comment

good solution! good solution! (undo)
- Cancel
Edit Your Reply (some HTML allowed)
What's the status of this problem?

@Shlomo, I will appreciate some info on what the problem is so that I can find a workaround on my end. This is a blocker.

How does this make you feel? Add Image

I'm
e.g. sad, anxious, confused, frustrated happy, confident, thankful, excited kidding, amused, unsure, silly indifferent, undecided, unconcerned
Cancel
0

Edit

Delete

Remove

Official

Fork

Abhishek Tiwari November 30, 2014 17:28

Same here...

Comment

good solution! good solution! (undo)
- Cancel
Edit Your Reply (some HTML allowed)
What's the status of this problem?

Same here...

How does this make you feel? Add Image

I'm
e.g. sad, anxious, confused, frustrated happy, confident, thankful, excited kidding, amused, unsure, silly indifferent, undecided, unconcerned
Cancel
This reply was removed on 2014-12-01.
see the change log
- Cancel
I’m frustrated

0

Edit

Delete

Remove

Official

Fork

Abhishek Tiwari December 01, 2014 06:29

Shlomo,

The target=_blank issue is becoming a showstopper for us. We heavily rely on opening new tabs to specific URLs and expect the extension to execute on those tabs. This works fine on Chrome and Firefox.

Please recommend a workaround where we can execute the extension on these pages.

Comment

good solution! good solution! (undo)
- view 4 more comments
- Shlomo (Official Rep) December 01, 2014 12:56
  
  Hi Abhishek, please can you provide a code snippet or extension id and the steps for reproducing the problem and I'll investigate.
  
  Edit
  
  Delete
  
  Remove
- Cancel
- Abhishek Tiwari December 01, 2014 16:50
  
  Shlomo,
  
  68111
  
  Edit
  
  Delete
  
  Remove
- Cancel
- Shlomo (Official Rep) December 02, 2014 10:52
  
  I checked the extension but I can't see any pages opened using _blank. Can you point out where this is in your code?
  
  Edit
  
  Delete
  
  Remove
- Cancel
- Abhishek Tiwari December 03, 2014 06:10
  
  Shlomo,
  
  I have disabled that for now to ensure the extension works. I open all new pages on _self.
  
  Edit
  
  Delete
  
  Remove
- Cancel
- Shlomo (Official Rep) December 03, 2014 18:50
  
  Then please an you provide a minimal extension that demonstrates the problem and I'll be happy to take a look.
  
  Edit
  
  Delete
  
  Remove
- Cancel
- Abhishek Tiwari December 05, 2014 02:21
  
  Shlomo,
  
  Following Sujoy's instructions above will get you the demonstration you need.
  Since my app is in production, I have disabled _blanks, so we cant use that app for the demo of this problem.
  
  I recommend following Sujoy's outlined instructions here with any of your current demo apps.
  
  Also recommend doing this test on Safari on Yosemite. I am noticing additional issues there. More on that later, once I have additional clarity.
  
  Edit
  
  Delete
  
  Remove
- Cancel
- Cancel
Edit Your Reply (some HTML allowed)
What's the status of this problem?

Shlomo, The target=_blank issue is becoming a showstopper for us. We heavily rely on opening new tabs to specific URLs and expect the extension to execute on those tabs. This works fine on Chrome and Firefox. Please recommend a workaround where we can execute the extension on these pages.

How does this make you feel? Add Image

I'm
e.g. sad, anxious, confused, frustrated happy, confident, thankful, excited kidding, amused, unsure, silly indifferent, undecided, unconcerned
Cancel
0

Edit

Delete

Remove

Official

Fork

Anton December 05, 2014 02:47

Could this issue be the same as https://getsatisfaction.com/crossride...?

Comment

good solution! good solution! (undo)
- Cancel
Edit Your Reply (some HTML allowed)
What's the status of this problem?

Could this issue be the same as https://getsatisfaction.com/crossrider/topics/safari-extension-scope-not-running-on-pre-opened-browser-pages?

How does this make you feel? Add Image

I'm
e.g. sad, anxious, confused, frustrated happy, confident, thankful, excited kidding, amused, unsure, silly indifferent, undecided, unconcerned
Cancel
0

Edit

Delete

Remove

Official

Fork

Abhishek Tiwari December 05, 2014 02:56

Anton,

This might partially be true. What I have found that the tabs which are opened with a directive of opening of new tab have this issue.

These tabs could have opened from window.open from Javascript or simple a href with target=_blank.

Somehow the extension is not executed on these pages. I have tried to reproduce this with other popular extensions like Pinterest and Pocket and dont see an issue. They seem to work fine.

So that leads me to conclude that it is a native crossrider issue, which needs to be looked at.

Comment

good solution! good solution! (undo)
- view 0 more comments
- Shlomo (Official Rep) December 07, 2014 09:28
  
  Thanks Abishek. The dev team will investigate and I'll report back their findings.
  
  Edit
  
  Delete
  
  Remove
- Cancel
- Abhishek Tiwari December 09, 2014 18:03
  
  Shlomo,
  
  Any word on this? Seems like a serious thing which might be impacting all the extensions on Safari
  
  Edit
  
  Delete
  
  Remove
- Cancel
- Cancel
Edit Your Reply (some HTML allowed)
What's the status of this problem?

Anton, This might partially be true. What I have found that the tabs which are opened with a directive of opening of new tab have this issue. These tabs could have opened from window.open from Javascript or simple a href with target=_blank. Somehow the extension is not executed on these pages. I have tried to reproduce this with other popular extensions like Pinterest and Pocket and dont see an issue. They seem to work fine. So that leads me to conclude that it is a native crossrider issue, which needs to be looked at.

How does this make you feel? Add Image

I'm
e.g. sad, anxious, confused, frustrated happy, confident, thankful, excited kidding, amused, unsure, silly indifferent, undecided, unconcerned
Cancel
1

Edit

Delete

Remove

Official

Fork

Sujoy Gupta December 09, 2014 19:17
@Abhishek, while the Crossrider team is looking into this, if you have control over how the link is rendered, there is a workaround for Safari.

Here is what we do:

// On the page
```
if (browser.SAFARI) {

	var tokens = location.pathname.split("/");

	tokens.pop();

	tokens.push(path);

	var url = location.origin + tokens.join("/");

        $('body').fireExtensionEvent('open', url);

  };

} else {

        window.open(path);

}
```
// In the extension, in extension.js
```
$('body').bindExtensionEvent('open', function (e, url) {

    appAPI.openURL({url: url, where: 'tab'});

});
```
Essentially on Safari, pages are opened by sending a message to the extension, and in all other browsers, standard window.open(..) is used. This ensures that extension is initialized properly in all browsers.
Comment

good solution! good solution! (undo)
- view 1 more comment
- Abhishek Tiwari December 09, 2014 19:28
  
  Quick question: What is the path variable in the page code? Also why does URL need so much massaging before sending to the extension?
  
  Edit
  
  Delete
  
  Remove
- Cancel
- Sujoy Gupta December 09, 2014 19:39
  
  path is your path that you need to open. URL needs massaging because extension needs a full URL to open a tab which may not be present on the link.
  
  I will encourage you to do further investigation yourself and post what you find.
  
  Edit
  
  Delete
  
  Remove
- Cancel
- Abhishek Tiwari December 09, 2014 19:41
  
  Yes will do. Btw have you tested on Safari 8?
  See my issue for that here: https://getsatisfaction.com/crossride...
  
  Maybe you can chime in with data if you see any problems
  
  Edit
  
  Delete
  
  Remove
- Cancel
- Cancel
Edit Your Reply (some HTML allowed)
What's the status of this problem?

@Abhishek, while the Crossrider team is looking into this, if you have control over how the link is rendered, there is a workaround for Safari. Here is what we do: // On the page <pre> if (browser.SAFARI) { var tokens = location.pathname.split("/"); tokens.pop(); tokens.push(path); var url = location.origin + tokens.join("/"); $('body').fireExtensionEvent('open', url); }; } else { window.open(path); } </pre> // In the extension, in extension.js <pre> $('body').bindExtensionEvent('open', function (e, url) { appAPI.openURL({url: url, where: 'tab'}); }); </pre> Essentially on Safari, pages are opened by sending a message to the extension, and in all other browsers, standard window.open(..) is used. This ensures that extension is initialized properly in all browsers.

How does this make you feel? Add Image

I'm
e.g. sad, anxious, confused, frustrated happy, confident, thankful, excited kidding, amused, unsure, silly indifferent, undecided, unconcerned
Cancel
0

Edit

Delete

Remove

Official

Fork

Abhishek Tiwari December 09, 2014 19:26

Sujoy,

That is an excellent suggestion. Let me give that a shot.
If that works, I owe you a beer ;-)

Abhishek

Comment

good solution! good solution! (undo)
- Cancel
Edit Your Reply (some HTML allowed)
What's the status of this problem?

Sujoy, That is an excellent suggestion. Let me give that a shot. If that works, I owe you a beer ;-) Abhishek

How does this make you feel? Add Image

I'm
e.g. sad, anxious, confused, frustrated happy, confident, thankful, excited kidding, amused, unsure, silly indifferent, undecided, unconcerned
Cancel
0

Edit

Delete

Remove

Official

Fork

Sujoy Gupta December 09, 2014 19:27

@Shlomo, the workaround only works if the page has been rendered by the extension developer. This won't work for a random page opened in Safari. Therefore, the issue still needs to be fixed.

Comment

good solution! good solution! (undo)
- Cancel
Edit Your Reply (some HTML allowed)
What's the status of this problem?

@Shlomo, the workaround only works if the page has been rendered by the extension developer. This won't work for a random page opened in Safari. Therefore, the issue still needs to be fixed.

How does this make you feel? Add Image

I'm
e.g. sad, anxious, confused, frustrated happy, confident, thankful, excited kidding, amused, unsure, silly indifferent, undecided, unconcerned
Cancel
0

Edit

Delete

Remove

Official

Fork

Abhishek Tiwari December 09, 2014 19:29

This would work for pages opened from our website. Would still be a problem for other pages opened by the users.

Comment

good solution! good solution! (undo)
- view -1 more comments
- Shlomo (Official Rep) December 10, 2014 05:39
  
  Thanks guys, we are looking into the issue and I'll discuss it further with the dev team.
  
  Edit
  
  Delete
  
  Remove
- Cancel
- Cancel
Edit Your Reply (some HTML allowed)
What's the status of this problem?

This would work for pages opened from our website. Would still be a problem for other pages opened by the users.

How does this make you feel? Add Image

I'm
e.g. sad, anxious, confused, frustrated happy, confident, thankful, excited kidding, amused, unsure, silly indifferent, undecided, unconcerned
Cancel
0

Edit

Delete

Remove

Official

Fork

Abhishek Tiwari December 12, 2014 22:36

Shlomo,

Any further update on this issue?

Comment

good solution! good solution! (undo)
- view -1 more comments
- Shlomo (Official Rep) December 14, 2014 10:33
  
  Currently there is no further update on this issue.
  
  Edit
  
  Delete
  
  Remove
- Cancel
- Cancel
Edit Your Reply (some HTML allowed)
What's the status of this problem?

Shlomo, Any further update on this issue?

How does this make you feel? Add Image

I'm
e.g. sad, anxious, confused, frustrated happy, confident, thankful, excited kidding, amused, unsure, silly indifferent, undecided, unconcerned
Cancel
0

Edit

Delete

Remove

Official

Fork

Abhishek Tiwari January 16, 2015 22:05

Finally got around to trying the technique Sujoy provided.
However that is also not fully guaranteed in the first use. In subsequent uses it seems to work most of the time.

Comment

good solution! good solution! (undo)
- Cancel
Edit Your Reply (some HTML allowed)
What's the status of this problem?

Finally got around to trying the technique Sujoy provided. However that is also not fully guaranteed in the first use. In subsequent uses it seems to work most of the time.

How does this make you feel? Add Image

I'm
e.g. sad, anxious, confused, frustrated happy, confident, thankful, excited kidding, amused, unsure, silly indifferent, undecided, unconcerned
Cancel
0

Edit

Delete

Remove

Official

Fork

Abhishek Tiwari January 16, 2015 22:50

Additionally I am using the sidebar plugin, which is having issues on some pages. That still doesnt load even if I load the page via the extension....

Comment

good solution! good solution! (undo)
- Cancel
Edit Your Reply (some HTML allowed)
What's the status of this problem?

Additionally I am using the sidebar plugin, which is having issues on some pages. That still doesnt load even if I load the page via the extension....

How does this make you feel? Add Image

I'm
e.g. sad, anxious, confused, frustrated happy, confident, thankful, excited kidding, amused, unsure, silly indifferent, undecided, unconcerned
Cancel

Reply to This Topic (some HTML allowed)
What's the status of this problem?

How does this make you feel? Add Image

I'm
e.g. sad, anxious, confused, frustrated happy, confident, thankful, excited kidding, amused, unsure, silly indifferent, undecided, unconcerned

About this Problem

Official Representatives

Products & Services

Tagged

The mood in here

appAPI.ready() does not fire on tabs on Safari opened by clicking on links with target="_blank".

Edit Subject

About this Problem

Official Representatives

Products & Services

Tagged

The mood in here

appAPI.ready() does not fire on tabs on Safari opened by clicking on links with target="_blank". Edit Subject

appAPI.ready() does not fire on tabs on Safari opened by clicking on links with target="_blank".

Edit Subject