Why still no websocket support for Android?

  • 4
  • Idea
  • Updated 6 years ago
  • Implemented
Hi, I am using this great plugin https://github.com/mkuklis/phonegap-w... for websocket support in Android. I sent several request to add it as 3rd party plugin to Phonegap Build, but had no luck.

Why there are still no solutions for websocket support in Android?
Photo of Andrey Perliev

Andrey Perliev

  • 2 Posts
  • 0 Reply Likes

Posted 7 years ago

  • 4
Photo of Hyginus Ugwumba

Hyginus Ugwumba

  • 1206 Posts
  • 42 Reply Likes
Hi Andrey,

The best thing to do is to follow up with the plugin owner.

I hope this idea can help you.

Thanks
Photo of Michal Kuklis

Michal Kuklis

  • 16 Posts
  • 5 Reply Likes
Hi Hyginus,

I'm the plugin owner and I requested multiple times to add the plugin to your registry but without any luck. The problem is that I'm including a jar file (which is open source MIT) and you guys are having some legal concerns about it which does not make any sense. Perhaps you will be able to help me here. Thanks!
Photo of Hyginus Ugwumba

Hyginus Ugwumba

  • 1206 Posts
  • 42 Reply Likes
Hi Michal,

You will need to submit this plugin for approval before it can be available for phonegap build services. if you have done this process before now, we cannot actually help, you may take a look on the guide for build plugin to be sure you have not missed and major requirement.

Links

https://build.phonegap.com/plugins

https://build.phonegap.com/docs/plugi...

Thanks
Hyginus
Photo of Michal Kuklis

Michal Kuklis

  • 16 Posts
  • 5 Reply Likes
Hi Hyginus,

Yes I did that twice (I followed all the rules) and I got rejected because my plugin contains jar file with prebuilt https://github.com/TooTallNate/Java-W... which is MIT. I'm still confused why you don't allow for that...
Photo of ismael jimoh

ismael jimoh

  • 4116 Posts
  • 192 Reply Likes
Hi Michal, Andrey

Would try to bring this up in our next meeting and from that would be able to give you both a detailed response on why it was rejected.

Thanks for your understanding.

Ismael
Photo of Michal Kuklis

Michal Kuklis

  • 16 Posts
  • 5 Reply Likes
Ismael any update on this? It has been 3 months :)
Photo of scriptguru

scriptguru

  • 6 Posts
  • 3 Reply Likes
Any update on the topic, anyone?

I think it's quite crucial to have this plugin available for cloud build.
Photo of Performance Total

Performance Total

  • 4 Posts
  • 1 Reply Like
Hi,

Any updates on this topic ?

Thanks
Photo of ismael jimoh

ismael jimoh

  • 4116 Posts
  • 192 Reply Likes
Hi Performance Total,

Unfortunately, there is currently no plugins for this.

We will welcome contributors willing to write one though.

Thanks.

Ismael
Photo of Michal Kuklis

Michal Kuklis

  • 16 Posts
  • 5 Reply Likes
Ismael I created a plugin for it but you guys have/had some issues with publishing it. Previously you've said:

"Would try to bring this up in our next meeting and from that would be able to give you both a detailed response on why it was rejected."

I was wondering if you get any response regarding it. Thanks.

Michal
Photo of ismael jimoh

ismael jimoh

  • 4116 Posts
  • 192 Reply Likes
No.

Would recommend you unzip it.

Reason for rule is to ensure all code visible and also avoid usage of libraries that you are not the original author hence avoiding any issues if there is a license with such a jar.

Ismael
Photo of Michal Kuklis

Michal Kuklis

  • 16 Posts
  • 5 Reply Likes
Ismael I just removed the jar and added source. I will republish it again. Thanks.
Photo of Michal Kuklis

Michal Kuklis

  • 16 Posts
  • 5 Reply Likes
Ismael I republished it: https://build.phonegap.com/plugins/93
and now I see:
Status: Rejected
Reason: Unable to clone git repository

git clone https://github.com/mkuklis/phonegap-w...

works fine to me. Can you explain why I was rejected again?

Thanks.
Michal
Photo of ismael jimoh

ismael jimoh

  • 4116 Posts
  • 192 Reply Likes
Hi Michal,

Sorry for the inconvenience and thanks for the persistence with submitting the plugin.

The error you saw is because PGB is currently unable to pull from the repo.

Can you try again in a while?

Thanks again.

Ismael
Photo of Michal Kuklis

Michal Kuklis

  • 16 Posts
  • 5 Reply Likes
Ok I will try in a while. Thank you Ismael.
Photo of scriptguru

scriptguru

  • 6 Posts
  • 3 Reply Likes
Looks like we are walking circles here.

The pluging is created, there are lots of people who want to use it with PhoneGap Build, and for no reason it is still not added to the list of standard plugins.
Photo of Amir

Amir

  • 8261 Posts
  • 263 Reply Likes
https://build.phonegap.com/plugins/add

Point #3 - Plugins must be source only and contain no binary code.

If you really need this https://github.com/TooTallNate/Java-W... then merge their source files with the plugins.

Thanks.
Photo of Michal Kuklis

Michal Kuklis

  • 16 Posts
  • 5 Reply Likes
Amir I republished it: https://build.phonegap.com/plugins/93
and now I see:
Status: Rejected
Reason: Unable to clone git repository

git clone https://github.com/mkuklis/phonegap-w...

works fine to me. Can you explain why I was rejected again?

Thanks.
Michal
Photo of Michal Kuklis

Michal Kuklis

  • 16 Posts
  • 5 Reply Likes
Amir can you explain why you guys have this rule in place? The library has a lot of files and that's why jars exist to make it a little bit simpler. I would have to list every single file from Java-WebSocket in your config.xml to be properly installed. Right now I can just do:

source-file src="libs/java_websocket.jar" target-dir="libs"

Which is much simpler.

I'm just confused about this for a long time now and nobody from Adobe/Phonegap gave me a clear answer here.
Yes I know the point #3 exists but why???

It makes it harder for 3td party developers to contribute to your framework.
Photo of Michal Kuklis

Michal Kuklis

  • 16 Posts
  • 5 Reply Likes
Amir I removed the jar and added source. I will try to republish it again. Thanks.
Photo of Performance Total

Performance Total

  • 4 Posts
  • 1 Reply Like
Hi Michal,

I don't know how long it's still going to take to have your plugin available, but I would like to thank you for your work and persistence.

I would really need to use websockets and use the Phonegap Build, so I thank you for your effort. Let's see if this can be overcome quickly, that would help me quite a bit.

Cheers !
Photo of Brett

Brett, OFFICIAL REP

  • 547 Posts
  • 54 Reply Likes
hey michal,

plugin looks good, but *all* files have to be listed in the plugin.xml, sadly.
Photo of Michal Kuklis

Michal Kuklis

  • 16 Posts
  • 5 Reply Likes
Thanks Brett, yes this is pretty inconvenient. Is there a reason why plugman doesn't just remove folders with source code from the installed plugin? Are you guys open to changes to your plugman implementation? Is this where the uninstall happens?
https://github.com/apache/cordova-plu...
Photo of Michal Kuklis

Michal Kuklis

  • 16 Posts
  • 5 Reply Likes
Brett I just tried to install the plugin with:

cordova plugin add https://github.com/mkuklis/phonegap-w...

and was able to uninstall it clearly with:

cordova plugin remove com.ququplay.websocket.WebSocket

I don't see any left over files after remove is complete. Could you explain why you guys have this requirement in place?

Thank you
Photo of Michal Kuklis

Michal Kuklis

  • 16 Posts
  • 5 Reply Likes
Brett I just resubmitted it again with all source files listed as requested. Thanks.
Photo of Michal Kuklis

Michal Kuklis

  • 16 Posts
  • 5 Reply Likes
Brett I tried to resubmit it but there is a problem with pulling it from the github. Every time I try to resubmit it I'm getting: "Unable to clone git repository". Can you please fix it?
Photo of Michal Kuklis

Michal Kuklis

  • 16 Posts
  • 5 Reply Likes
Hi guys I just wanted to let you know that the plugin was finally approved by the Phonegap/Adobe team: https://build.phonegap.com/plugins/478 Thanks!
Photo of Performance Total

Performance Total

  • 4 Posts
  • 1 Reply Like
Thank you Michal, I'll try to give it a go this week !
Photo of ismael jimoh

ismael jimoh

  • 4116 Posts
  • 192 Reply Likes
Thanks for the contribution Michal.

Really appreciated.

Ismael
Photo of scriptguru

scriptguru

  • 6 Posts
  • 3 Reply Likes
Michal, thanks a lot for creating the plugin and being persistant!
PhoneGap Build team and especially Brett, thanks for taking this issue seriously and resolving the problem!
Photo of Andrey Perliev

Andrey Perliev

  • 2 Posts
  • 0 Reply Likes
Excellent! Michal, thanks!
Photo of Performance Total

Performance Total

  • 4 Posts
  • 1 Reply Like
Once again, Michal, thank you for your work and persistence. Now to try it...
Photo of Cabassut Frédéric

Cabassut Frédéric

  • 1 Post
  • 0 Reply Likes
thank you so much Michal!!

This conversation is no longer open for comments or replies.