iframe for Tumblr controls breaks XHTML validation

  • Problem
  • Updated 6 years ago
The following snippet of code, located right before the closing body-tag, breaks XHTML validation, due to the fact that 'border' and 'allowTransparency' are not valid attributes.


<!-- BEGIN TUMBLR CODE -->
&lt;iframe src="http://www.tumblr.com/dashboard/iframe?src=http%3A%2F%2Fthesmilingpenguin.com%2F" border="0" scrolling="no" width="278" height="25" allowTransparency="true" frameborder="0" style="position:absolute; z-index:1337; top:0px; right:0px; border:0px; background-color:transparent; overflow:hidden;" id="tumblr_controls"&gt;&lt;/iframe&gt;
<!-- END TUMBLR CODE -->


Additionally, the source document of the iframe contains the following errors:

line 6 column 10 - Error: end tag for "head" which is not finished
line 9 column 10 - Error: required attribute "type" not specified
line 9 column 10 - Error: document type does not allow element "style" here

It would be nice to have this fixed, since most of the errors seem pretty simple to correct. Even better would be to drop the iframe altogether, since it belongs in the 90's together with the VCR and fanny packs ;)

Thank you for your time.

Regards,
Martin
http://thesmilingpenguin.com
Photo of Martin Häger

Martin Häger

  • 4 Posts
  • 0 Reply Likes
  • annoyed

Posted 7 years ago

  • 26
Photo of David Kaneda

David Kaneda

  • 16 Posts
  • 3 Reply Likes
I've given up on validation for a while now, but I do think it's a very worthwhile effort, and could be dissuading some potential users. In addition to the iframe issues presented, audio/video encoding is also invalid - (though, I understand writing a Javascript wrapper in the template system would be difficult)

Thanks-
Photo of lucas garber

lucas garber

  • 3 Posts
  • 0 Reply Likes
It really shouldn't be too hard to rewrite the iframe markup to something that is valid in all versions of html and xhtml.

Or have it just add a div instead of an iframe (since iframes are not valid for xhtml strict.

if it is essential to have it as an iframe then it could be just a div with the id of "tumbrcode" and then a simple javascript to add it since the html validators ignore changes via javascript.
Photo of Martin Häger

Martin Häger

  • 4 Posts
  • 0 Reply Likes
Hey, I had almost forgotten about this thread. Anyway, this is easy to fix - just do something like this:


&lt;style type="text/css"&gt;
#tumblr-bar {
position: absolute;
top: 0;
right: 0;
z-index: 9999;
background: red;
}
&lt;/style&gt;

&lt;div id="tumblr-bar"&gt;
Oh, hai. I'm a Tumblr bar!
&lt;/div&gt;
Photo of jyoseph

jyoseph

  • 18 Posts
  • 1 Reply Like
Yes, this should be fixed. Super easy fix. Please do it. Thanks in advance.
Photo of

  • 1 Post
  • 0 Reply Likes
+1 to fix this one.
I like clean and validating pages =)
Photo of ekz4

ekz4

  • 1 Post
  • 0 Reply Likes
+1 plz fix this problem
Photo of Miladinoski

Miladinoski

  • 1 Post
  • 0 Reply Likes
Fix the problem, I really need my page to validate!
Photo of Melissa

Melissa

  • 2 Posts
  • 0 Reply Likes
I agree with this! There are simple ways to fix it. Users who don't care won't be affected by it and users who do will be extremely grateful!
Photo of

  • 1 Post
  • 0 Reply Likes
It's sooo easy to fix it.
Photo of lucas garber

lucas garber

  • 3 Posts
  • 0 Reply Likes
Does anyone from Tumblr.com read these things? I've not seen any progress on this... i mean, tumblr's a great service but little things like this annoy me...

You get a service/site that's 95% perfect and then that last little 5% just stares at you.
Photo of Nch Roman

Nch Roman

  • 1 Post
  • 0 Reply Likes
I agree, this should be fixed. It is simple to fix and it will show respect to the w3c's job.
Photo of Melissa

Melissa

  • 2 Posts
  • 0 Reply Likes
Still no progress on this? C'mon, Tumblr...
Photo of lucas garber

lucas garber

  • 3 Posts
  • 0 Reply Likes
c'mon tumblr! don't you care? i guess not.